Don't call out to run sed if you have re, see my commit suggestion for the first of these filter functions.

See the other changes to commit (can be committed using the commit buttons, and SYSCONFIG_SNMPD = '/etc/sysconfig/snmpd'.

I'm wondering if the consecutive empty lines in the example snmpd.conf can be removed.

PS: I thought I had seen some trailing spaces at other places in git diff but have no enough time to check it now for verification.

Commit removal of trailing spaces.

The test suite log (unfold the Checks section, click on Details and then on the Python2 GitHub action test run to find it) shows that all the greps fail to find the paths that they should grep:

https://github.com/xenserver/status-report/actions/runs/6938095957/job/18873299352?pr=22

+ grep -q 'snmpv2cpublic\|0xsnmpv3authenticationkey\|0xsnmpv3privacykey' /code/status-report/.tmp/tests/snmp/tar/snmp_xs_conf.out
grep: /code/status-report/.tmp/tests/snmp/tar/snmp_xs_conf.out: No such file or directory
+ grep -q snmpv2cpublic /code/status-report/.tmp/tests/snmp/tar/snmpd_xs_conf.out
grep: /code/status-report/.tmp/tests/snmp/tar/snmpd_xs_conf.out: No such file or directory
+ grep -q '0xsnmpv3authenticationkey\|0xsnmpv3privacykey' /code/status-report/.tmp/tests/snmp/tar/snmpd_conf.out
grep: /code/status-report/.tmp/tests/snmp/tar/snmpd_conf.out: No such file or directory

Also, they should not check the presence of certain string like they attempt to do here.

Instead, they should check two things:

1. The test should assert that the dummy secrets present in the test template files are NOT found anywhere in the archived output!
2. The test should assert that the diff between the actual file and the filtered output is only that the secrets are replaced with REMOVED, and other lines are not changed.

This could better be implemented based on the new pytest framework to be merged with #25, where you can implement and test these assertions locally by just running pytest tests/integration -rA` and improve it directly on a Linux development machine (like the Eddie3 in the UK) or any other Linux including WSL2 instances on Windows hosts.

@bernhardkaindl I created another ticket CP-46759 to add testcases for collecting SNMP config files. Please merge the current commit into the feature branch.
After I finish the testcases, I will create another PR for testcases and merge it into the feature branch.
After the 2 commits are merged into the feature branch, please merge the feature branches into the master branch.
Thanks.

Yep, that's perfect!
It's also a great idea to add the testcases as a 2nd, separate commit!